[SeaBIOS] [PATCH for-1.10-stable] drop "etc/boot-cpus" fw_cfg file and reuse legacy QEMU_CFG_NB_CPUS

Kevin O'Connor kevin at koconnor.net
Mon Nov 21 16:19:42 CET 2016


On Mon, Nov 21, 2016 at 11:56:35AM +0100, Igor Mammedov wrote:
> On Tue, 15 Nov 2016 11:36:21 +0100
> Gerd Hoffmann <kraxel at redhat.com> wrote:
> 
> > On So, 2016-11-13 at 23:05 -0500, Kevin O'Connor wrote:
> > > On Fri, Nov 11, 2016 at 04:35:15PM +0100, Igor Mammedov wrote:  
> > > > since QEMU_CFG_NB_CPUS not going away anytime soon
> > > > and serves the same purpose as just added "etc/boot-cpus" fw_cfg
> > > > drop support for "etc/boot-cpus" while this code is not
> > > > in use yet (i.e. QEMU with "etc/boot-cpus" hasn't been released)
> > > > and reuse QEMU_CFG_NB_CPUS instead of it.  
> > > 
> > > I'm okay with this change.  I'd like to get Gerd's comments as well
> > > though as the patch is targeted for a stable branch.  
> > 
> > Looks good to me too.  I should have remembered this before as I
> > actually added QEMU_CFG_NB_CPUS support to coreboot ...
> > 
> > Process as usual: commit to qemu first, then seabios (master goes first,
> > then cherry-pick into stable), then update seabios binaries in qemu.
> > 
> > cheers,
> >   Gerd
> > 
> 
> QEMU part has been merged to master:
>  e3cadac07 pc: fix FW_CFG_NB_CPUS to account for -device added CPUs
> 
> Gerd,
> Could you take care about applying this patch to SeaBIOS (+stable)
> and updating SeaBIOS blob and QEMU?

FYI, I committed this change to the SeaBIOS master branch.

Thanks,
-Kevin



More information about the SeaBIOS mailing list