[SeaBIOS] [PATCH 1/3] vgabios: Remove special case of dh==0xff in handle_1013()

Kevin O'Connor kevin at koconnor.net
Mon Jul 4 18:41:14 CEST 2016


The original "lgpl vgabios" had a special case for dh==0xff in its
int1013 (write string) code.  There does not appear to be any VGABIOS
documentation supporting this as an externally available feature.  It
appears this was for its own internal use when writing its strings to
the screen.  SeaVGABIOS doesn't use this hack; this patch removes it
from the code.

Signed-off-by: Kevin O'Connor <kevin at koconnor.net>
---
 vgasrc/vgabios.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/vgasrc/vgabios.c b/vgasrc/vgabios.c
index f07e85b..8b50192 100644
--- a/vgasrc/vgabios.c
+++ b/vgasrc/vgabios.c
@@ -1030,13 +1030,7 @@ handle_1012(struct bregs *regs)
 static void noinline
 handle_1013(struct bregs *regs)
 {
-    struct cursorpos cp;
-    if (regs->dh == 0xff)
-        // if row=0xff special case : use current cursor position
-        cp = get_cursor_pos(regs->bh);
-    else
-        cp = (struct cursorpos) {regs->dl, regs->dh, regs->bh};
-
+    struct cursorpos cp = {regs->dl, regs->dh, regs->bh};
     u16 count = regs->cx;
     u8 *offset_far = (void*)(regs->bp + 0);
     u8 attr = regs->bl;
-- 
2.5.5




More information about the SeaBIOS mailing list