[SeaBIOS] [PATCH v2 0/6] Fixes for physical presence and API

Kevin O'Connor kevin at koconnor.net
Thu Jan 7 17:19:30 CET 2016


On Thu, Jan 07, 2016 at 07:55:35AM -0500, Stefan Berger wrote:
> Patch 1 fixes the return of a missing digest in the HashLogExtendEvent command.
> 
> Beyond thad that, the patches extend the handling of physical presence to HW
> physical presence and rework the showing of the TPM menu to depend on whether
> SW physical presence could be asserted or HW physical presence has been found
> to be enabled.

Thanks.  In general it looks good to me.  However, it looks like you
applied your patches on top of my testing branch instead of on top of
the master branch.  My testing branch diverged from master (I didn't
apply patch 8, and I fixed a couple of typos before committing to
master).

I merged your patches into master and put them back to the (now
updated) testing branch:
  https://github.com/KevinOConnor/seabios/tree/testing

Also, each patch in the series should have "tpm: " prefaced to the
subject and I have three comments in patches 4 and 5.  They are minor,
so I can fix these on commit if you wish - let me know.

-Kevin



More information about the SeaBIOS mailing list