[SeaBIOS] [PATCH 2/2] tpm: Write logs in TPM 2 format

Stefan Berger stefanb at linux.vnet.ibm.com
Fri Feb 26 19:28:14 CET 2016


On 02/23/2016 11:53 AM, Kevin O'Connor wrote:
> On Mon, Feb 08, 2016 at 11:36:40AM -0500, Kevin O'Connor wrote:
>> On Mon, Feb 08, 2016 at 07:25:35AM -0500, Stefan Berger wrote:
>>> On 02/06/2016 01:35 PM, Kevin O'Connor wrote:
>>>> Add support for the TPM 2 format of log messages.
>>>>
>>>> Write the logs in the format that is appropriate for the version of
>>>> the host's TPM. For TPM 1.2 write it in the 'pcpes' structure's
>>>> format, for TPM 2 in the new TPM 2 format.
>>>>
>>>> By using this method we can keep the API interface on systems with a
>>>> TPM 2 even though applications pass in the 'pcpes' structures
>>>> directly. The log will still be written in the appropriate format.
>>>>
>>>> The TPM 2 log contains a TPM 1.2 type of entry of event type
>>>> EV_NO_ACTION and entry of type TCG_EfiSpeIdEventStruct as the first
>>>> entry. This is described in the EFI specification (section 5.3):
>>>>
>>>> Signed-off-by: Kevin O'Connor <kevin at koconnor.net>
> Hi Stefan,
>
> I updated the patch with your feedback on an explicit version check
> instead of using EV_NO_ACTION.
>
> Are you okay with the patch below, and if so can I add your
> signed-off-by line?
>
> -Kevin
>
>
> commit 102648838c0cf640c01b5f092e8f432d8f2abb8f
> Author: Kevin O'Connor <kevin at koconnor.net>
> Date:   Fri Feb 5 22:28:17 2016 -0500
>
>      tpm: Write logs in TPM 2 format
>      
>      Add support for the TPM 2 format of log messages.
>      
>      Write the logs in the format that is appropriate for the version of
>      the host's TPM. For TPM 1.2 write it in the 'pcpes' structure's
>      format, for TPM 2 in the new TPM 2 format.
>      
>      By using this method we can keep the API interface on systems with a
>      TPM 2 even though applications pass in the 'pcpes' structures
>      directly. The log will still be written in the appropriate format.
>      
>      The TPM 2 log contains a TPM 1.2 type of entry of event type
>      EV_NO_ACTION and entry of type TCG_EfiSpeIdEventStruct as the first
>      entry. This is described in the EFI specification (section 5.3):
>      
>      Signed-off-by: Kevin O'Connor <kevin at koconnor.net>
Signed-off-by: Stefan Berger <stefanb at linux.vnet.ibm.com>





More information about the SeaBIOS mailing list