[SeaBIOS] [PATCH 1/2] tpm: Unify tpm_fill_hash()/tpm_log_extend_event() and use in BIOS interface

Kevin O'Connor kevin at koconnor.net
Sat Feb 20 03:13:30 CET 2016


On Mon, Feb 08, 2016 at 07:19:27AM -0500, Stefan Berger wrote:
> On 02/06/2016 01:35 PM, Kevin O'Connor wrote:
> >Don't call tpm_fill_hash() or tpm_log_extend_event() from any internal
> >code (ie, tpm_add_measurement_to_log).  The internal code does not
> >require the additional checks that these functions provide.
> >
> >Unify the tpm_fill_hash() and tpm_log_extend_event() into a new
> >function hash_log_extend(), and use this function only in the 16bit
> >BIOS interface code.  With the code now specific to the BIOS interface
> >it can more easily return a BIOS specific error return code.
[...]
> 
> ACK.

Thanks - I pushed this change.  (I did not push patch 2.)

-Kevin



More information about the SeaBIOS mailing list