[SeaBIOS] [RFC] Document and rework debug levels

Gerd Hoffmann kraxel at redhat.com
Thu Apr 7 17:35:43 CEST 2016


  Hi,

> > > Maybe adding wrappers (eg, debug_mem("my message") ) for the common
> > > cases would avoid that problem.
> > 
> > would nicely imitate pr_*() from Linux's "include/linux/printk.h".
> 
> The printk.h code is interesting.  I'm now thinking it might be better
> to introduce pr_err (for level 1 above), pr_notice (for levels 2-4
> above), pr_info (for level 5), and pr_debug (for level 6).  The "debug
> level" would then just be an internal detail.

I think this is useful.  Having named pr_$what functions instead of
debug level numbers makes it more likely that people try to pick a good
category when coding.

cheers,
  Gerd




More information about the SeaBIOS mailing list