[SeaBIOS] [PATCH 0/3] Don't allow version override; use reproducible by default

[Kevin O'Connor]

On Thu, Oct 22, 2015 at 05:52:22PM +0200, Gerd Hoffmann wrote:
> > > One option I see is to consider builds clean in case EXTRAVERSION is
> > > present, so distros can simply set EXTRAVERSION to the rpm release.
> > 
> > So, consider the build clean if git does not exist, ".version" does
> > exist, and EXTRAVERSION is set?  That seems reasonable, if a bit
> > convoluted.  The key would be letting distribution builders know about
> > this and to document what information we expect to be contained in the
> > EXTRAVERSION field.
> 
> Yes, that should be documented of course.

Okay - I sent a couple of patches to the list for review.

> > > Or add a new variable specifically for package build versioning, and
> > > possibly even set that automatically.  rpm sets some environment
> > > variables in the build environment ....
> > 
> > That's also possible (buildversion.py could check for common package
> > building environment variables), but I suspect that different distros
> > use different variables.
> 
> Depends on the packaging tool, not the distro, so it'll be the same for
> all rpm-based distros (redhat, suse, ...).  dpkg has other variables,
> but again it should be same for all distros using it (debian,
> ubuntu, ...).  So there shouldn't be *that* many different cases.

Well, there's also Arch and likely others.  If someone wants to send a
patch then we can take a look.  My initial thought is that it seems a
bit complex.

-Kevin