[SeaBIOS] [PATCH 0/7] Some TPM code reorganization

[Stefan Berger]

On 11/28/2015 07:44 AM, Kevin O'Connor wrote:
> On Tue, Nov 24, 2015 at 12:40:32PM -0500, Stefan Berger wrote:
>> On 11/23/2015 11:40 PM, Kevin O'Connor wrote:
>>> On Mon, Nov 23, 2015 at 11:17:35AM -0500, Kevin O'Connor wrote:
>>>> However, it seems like just undoing my
>>>> patch 4 makes the most sense.  I'll pull that patch out and repost
>>>> tonight.
>>> FYI, I modified the series (mostly reverted patch 4) and pushed to
>>> github:
>>>
>>>    https://github.com/KevinOConnor/seabios/tree/testing
>> Tested it. Works as before.
> Thanks - I pushed that code.
>
> Separately, is the call to PhysicalPresence_CMD_ENABLE in
> tpm_set_failure() correct, or should that be
> PhysicalPresence_CMD_DISABLE?

It's correct.
Per spec on TPM_SetTempDeactivated:

"This command allows the operator of the platform to deactivate the TPM 
until the next boot
of the platform.
This   command   requires   operator   authentication.   The operator   
can   provide   the
authentication by either the assertion of physical presence or 
presenting the operator
AuthData value"

      Stefan