[SeaBIOS] [PATCH 0/7] Some TPM code reorganization

Stefan Berger stefanb at linux.vnet.ibm.com
Mon Nov 23 00:54:47 CET 2015

On 11/22/2015 12:20 PM, Kevin O'Connor wrote:
> Hi Stefan,
> As part of trying to better understand the TPM code, I found some
> changes to tcgbios.c were helpful.  It's mostly code movement.  I've
> only compile tested these changes, but I think they are safe.
> I don't want to conflict with any changes you may have pending.  So,
> let me know if this is a problem.

I do have other changes and extensions pending, but go ahead and apply it.

> The series is on top of your latest patches.  (FYI, I made a minor
> change to a comment in your patch 2.)  I've also put this series (and
> your series) up at:
> https://github.com/KevinOConnor/seabios/tree/testing

I applied them locally. From what i can see from tests I have done, 
results are still like before.

ACK to series.


> -Kevin
> Kevin O'Connor (7):
>    tpm: Add "static" declaration to functions not used outside tcgbios.c
>    tpm: Move code around in tcgbios.c
>    tpm: Move error recovery from tpm_extend_acpi_log() to only caller
>    tpm: Open code tpm_ipl() into callers
>    tpm: Change tpm_add_measurement() to tpm_add_action()
>    tpm: Move tpm_add_bootdevice() into callers
>    tpm: Move tpm_start_option_rom_scan() and tpm_calling_int19h() into
>      callers
>   src/tcgbios.c | 1258 +++++++++++++++++++++++++--------------------------------
>   1 file changed, 556 insertions(+), 702 deletions(-)

More information about the SeaBIOS mailing list