[SeaBIOS] [PATCH 1/3] sdcard: Only enable error_irq_enable for bits defined in SDHCI v1 spec

Kevin O'Connor kevin at koconnor.net
Tue Nov 17 20:58:29 CET 2015


The SDHCI v1 spec only defines the first 9 error_irq_enable bits and
reserves other bits in the field.  Don't enable the 10th bit (which
was defined in the v2 spec) as it's not needed anyway.

Signed-off-by: Kevin O'Connor <kevin at koconnor.net>
---
 src/hw/sdcard.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/hw/sdcard.c b/src/hw/sdcard.c
index be726d2..0617d24 100644
--- a/src/hw/sdcard.c
+++ b/src/hw/sdcard.c
@@ -493,7 +493,7 @@ sdcard_controller_setup(struct sdhci_s *regs, int prio)
     writew(&regs->irq_enable, 0x01ff);
     writew(&regs->irq_status, readw(&regs->irq_status));
     writew(&regs->error_signal, 0);
-    writew(&regs->error_irq_enable, 0x03ff);
+    writew(&regs->error_irq_enable, 0x01ff);
     writew(&regs->error_irq_status, readw(&regs->error_irq_status));
     writeb(&regs->timeout_control, 0x0e); // Set to max timeout
     int volt = sdcard_set_power(regs);
-- 
2.4.3




More information about the SeaBIOS mailing list