[SeaBIOS] [PATCH 2/3] Support for TPM Physical Presence Interface

[Stefan Berger]

On 05/21/2015 01:46 PM, Kevin O'Connor wrote:
> On Fri, May 08, 2015 at 01:45:47PM -0400, Stefan Berger wrote:
>> This patch implements the specification found here:
>>
>> http://www.trustedcomputinggroup.org/resources/tcg_physical_presence_interface_specification
>>
>> It adds the necessary BIOS code so that for example an administrator can send
>> messages from the OS to the BIOS for the BIOS to change the state of the TPM
>> upon reboot. With the help of this interface, an administrator does not have
>> to manually interact with the BIOS.
> [...]
>> --- a/src/post.c
>> +++ b/src/post.c
>> @@ -219,6 +219,7 @@ maininit(void)
>>   
>>       // Setup platform devices.
>>       platform_hardware_setup();
>> +    tpm_ppi_init();
>>   
>>       // Start hardware initialization (if threads allowed during optionroms)
>>       if (threads_during_optionroms())
>> @@ -240,6 +241,8 @@ maininit(void)
>>       // Run option roms
>>       optionrom_setup();
>>   
>> +    // Process user-requested TPM state change
>> +    tpm_ppi_process();
> I think both of these calls should be folded into tpm_start().

Agreed. Done.

    Stefan