[SeaBIOS] [PATCH 3/3] Accept file supplied as multiboot modules

[Paolo Bonzini]

On 19/05/2015 10:10, Paolo Bonzini wrote:
> 
> 
> On 19/05/2015 09:47, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>> On 19.05.2015 09:45, Paolo Bonzini wrote:
>>>
>>>
>>> On 18/05/2015 22:07, Vladimir 'phcoder' Serbinenko wrote:
>>>> +void
>>>> +coreboot_multiboot_init(u32 mbptr)
>>>> +{
>>>> +  struct multiboot_info *mbi = (void *)mbptr;
>>>> +  dprintf (1, "mbptr=0x%x\n", mbptr);
>>>> +  if (mbptr == NO_MULTIBOOT)
>>>> +    return;
>>>> +  mbi = (void *)mbptr;
>>>> +  dprintf (1, "flags=0x%x, mods=0x%x, mods_c=%d\n", mbi->flags, mbi->mods_addr,
>>>> +	   mbi->mods_count);
>>>> +  if (!(mbi->flags & MULTIBOOT_INFO_MODS))
>>>> +    return;
>>>
>>> Can you make this dependent on a new Kconfig symbol?
>>>
>> What's the downsde of having it unconditionally in?
> 
> It makes the SeaBIOS binary bigger.

Also, it must depend on COREBOOT_FLASH, otherwise cbfs_copyfile is
compiled out and the functionality is broken.

Paolo