[SeaBIOS] [PATCH 3/3] Accept file supplied as multiboot modules

[Vladimir 'φ-coder/phcoder' Serbinenko]

On 19.05.2015 09:45, Paolo Bonzini wrote:
> 
> 
> On 18/05/2015 22:07, Vladimir 'phcoder' Serbinenko wrote:
>> +void
>> +coreboot_multiboot_init(u32 mbptr)
>> +{
>> +  struct multiboot_info *mbi = (void *)mbptr;
>> +  dprintf (1, "mbptr=0x%x\n", mbptr);
>> +  if (mbptr == NO_MULTIBOOT)
>> +    return;
>> +  mbi = (void *)mbptr;
>> +  dprintf (1, "flags=0x%x, mods=0x%x, mods_c=%d\n", mbi->flags, mbi->mods_addr,
>> +	   mbi->mods_count);
>> +  if (!(mbi->flags & MULTIBOOT_INFO_MODS))
>> +    return;
> 
> Can you make this dependent on a new Kconfig symbol?
> 
What's the downsde of having it unconditionally in?
> Thanks,
> 
> Paolo
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 213 bytes
Desc: OpenPGP digital signature
URL: <http://www.seabios.org/pipermail/seabios/attachments/20150519/803ea722/attachment.asc>