[SeaBIOS] [PATCH 3/3] Accept file supplied as multiboot modules

[Vladimir 'φ-coder/phcoder' Serbinenko]

> This code would need to be in the seabios coding style.
> 
Could you point to style guide or to tell exact points you dislike? STFW
"seabios style guide" returns no relevant results
> Instead of passing this variable all the way through these
> initialization functions, I suspect it would be much easier to just
> stash the value in a global variable in the assembler and then read it
> from that global in the coreboot.c code.
> 
Done.
> Why detect a multiboot entry in entry_elf - wouldn't it be much
> simpler to point the multiboot header to a new entry_multiboot
> assembler function?
> 
Done.
> 
> I don't understand this comment - seabios always uses -mregparam=3 and
> nearly all the assembler entry stubs rely on this.
> 
Removed.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: accept_multiboot.diff
Type: application/x-patch
Size: 12299 bytes
Desc: not available
URL: <http://www.seabios.org/pipermail/seabios/attachments/20150519/aa538bdf/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 213 bytes
Desc: OpenPGP digital signature
URL: <http://www.seabios.org/pipermail/seabios/attachments/20150519/aa538bdf/attachment-0001.asc>