[SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 00/25] hw/pc: implement multiple primary busses for pc machines

[Gerd Hoffmann]

On Mo, 2015-03-09 at 18:26 +0200, Marcel Apfelbaum wrote:
> On 03/09/2015 04:19 PM, Gerd Hoffmann wrote:
> >    Hi,
> >
> >> My series is based on commit 09d219a. Try please on top of this commit.
> >
> > Ok, that works.  Going to play with that now ;)
> Good luck! ... and tell me what you think :)
> If you need any help with the command line of the pxb device, let me know,.

First thing I've noticed:  You need to define a numa node so you can
pass a valid numa node to the pxb-device.  Guess that is ok as the whole
point of this is to assign pci devices to numa nodes.  More complete
test instructions would be nice though.

Second thing:  Booting with an unpatched seabios has bad effects:

[root at localhost ~]# cat /proc/iomem 
00000000-000fffff : PCI Bus 0000:10
  00000000-00000fff : reserved
  00001000-0009fbff : System RAM
  0009fc00-0009ffff : reserved
  000c0000-000c91ff : Video ROM
  000c9800-000ca1ff : Adapter ROM
  000ca800-000ccbff : Adapter ROM
  000f0000-000fffff : reserved
    000f0000-000fffff : System ROM
00100000-3ffdffff : System RAM
  01000000-0174bde4 : Kernel code
  0174bde5-01d30cff : Kernel data
  01eaa000-0202afff : Kernel bss
3ffe0000-3fffffff : reserved
fd000000-fdffffff : 0000:00:02.0
  fd000000-fdffffff : bochs-drm
febc0000-febdffff : 0000:00:03.0
  febc0000-febdffff : e1000
febf0000-febf0fff : 0000:00:02.0
  febf0000-febf0fff : bochs-drm
fec00000-fec003ff : IOAPIC 0
fed00000-fed003ff : HPET 0
  fed00000-fed003ff : PNP0103:00
fee00000-fee00fff : Local APIC
feffc000-feffffff : reserved
fffc0000-ffffffff : reserved

"PCI Bus 0000:10" is bogus and "PCI Bus 0000:00" isn't there at all.

cheers,
  Gerd