[SeaBIOS] [Qemu-devel] [PATCH v4 for-2.3 01/25] acpi: fix aml_equal term implementation

Igor Mammedov imammedo at redhat.com
Mon Mar 9 11:28:22 CET 2015


On Sun,  8 Mar 2015 13:16:03 +0200
Marcel Apfelbaum <marcel at redhat.com> wrote:

> The DefLEqual op does not have a target operand. Remove it.
> 
> Signed-off-by: Marcel Apfelbaum <marcel at redhat.com>
Reviewed-by: Igor Mammedov <imammedo at redhat.com>

> ---
>  hw/acpi/aml-build.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
> index 876cada..0d14561 100644
> --- a/hw/acpi/aml-build.c
> +++ b/hw/acpi/aml-build.c
> @@ -542,7 +542,6 @@ Aml *aml_equal(Aml *arg1, Aml *arg2)
>      Aml *var = aml_opcode(0x93 /* LequalOp */);
>      aml_append(var, arg1);
>      aml_append(var, arg2);
> -    build_append_int(var->buf, 0x00); /* NullNameOp */
It's just happens to work in case CPU and PCI hotplug because
it LEqual was the only predicate in if block and NullNameOp
was considered as part of inner code-block, like:
if (LEqual(a, b)) {
   NullName; // nop
   ...
}
>      return var;
>  }
>  




More information about the SeaBIOS mailing list