[SeaBIOS] [Qemu-devel] [PATCH v4 1/3] ich9: add TCO interface emulation

[Paolo Bonzini]

On 22/06/2015 14:44, Michael S. Tsirkin wrote:
> OK. Do you agree to move the ACPI bits to the SSDT, making
> it conditional on device being enabled?

Again, no.  The chipset configuration registers range is always defined
by the chipset, even if the TCO is not in use.  It would have to be
conditional on whether the RCBA is programmed by the firmware, not on
whether the TCO watchdog is enabled.  That's a very different patch, and
it's independent of DSDT vs. SSDT.

You have to draw a line between required work and nice-to-haves that the
maintainer can do himself.  Otherwise, the possibilities are:

1) the contributor is scared away, and we lose a valuable feature

2) the contributor does it, but then keeps all remaining contributions
in house because the first one was such a hell to go through.

Paolo