[SeaBIOS] [PATCH v3 2/3] target-i386: reserve RCRB mmio space in ACPI DSDT table

[Michael S. Tsirkin]

On Mon, Jun 01, 2015 at 08:48:40PM -0300, Paulo Alcantara wrote:
> v1 -> v2:
>   * s/PDRC/CCR/ for clarity and match ICH9 spec
>   * remove unnecessary OperationRegion for RCRB

changelog should come after ---.
An empty commit log is too terse I think.
Could you quote spec in the changelog?

> Signed-off-by: Paulo Alcantara <pcacjr at zytor.com>
> ---
>  hw/i386/q35-acpi-dsdt.dsl     |  14 ++++++++++++++
>  tests/acpi-test-data/q35/DSDT | Bin 7666 -> 7723 bytes
>  2 files changed, 14 insertions(+)
> 
> diff --git a/hw/i386/q35-acpi-dsdt.dsl b/hw/i386/q35-acpi-dsdt.dsl
> index 16eaca3..92675c8 100644
> --- a/hw/i386/q35-acpi-dsdt.dsl
> +++ b/hw/i386/q35-acpi-dsdt.dsl
> @@ -114,6 +114,20 @@ DefinitionBlock (
>          }
>      }
>  
> +/****************************************************************
> + * Chipset Configuration Registers
> + ****************************************************************/
> +Scope(\_SB.PCI0) {
> +    Device (CCR) {
> +        Name (_HID, EISAID("PNP0C02"))
> +        Name (_UID, 1)
> +
> +        Name (_CRS, ResourceTemplate() {
> +	    Memory32Fixed(ReadWrite, 0xfed1c000, 0x00004000) // RCBA

Indent a bit more please.

> +        })
> +    }
> +}
> +
>  #include "acpi-dsdt-hpet.dsl"
>  
>  
> diff --git a/tests/acpi-test-data/q35/DSDT b/tests/acpi-test-data/q35/DSDT
> index 4723e5954dccb00995ccaf521b7daf6bf15cf1d4..f3bda7b54ea6d669b1498d9380e7781207fb6e49 100644
> GIT binary patch
> delta 81
> zcmexlz1oJ$CD<iITaJN&F>xbTJfnq$UVN}qe1Nm3L3ERjvvW{9N4$rp3y<Rk9wv_X
> lP)`>|j(F#wU_n7HzBWz<Mur0y|1mf)FjO*Z&S3140RVI`6(s-w
> 
> delta 24
> gcmZ2&^U0daCD<k8lPm)R<DrdQ at r;`nF?PxT0Bl$YHUIzs
> 
> -- 
> 2.1.0