[SeaBIOS] [PATCH v2 1/3] Add 'measurement' code to the BIOS

[Stefan Berger]

On 06/01/2015 12:36 PM, Kevin O'Connor wrote:
> On Tue, May 26, 2015 at 03:48:33PM -0400, Stefan Berger wrote:
>> This patch adds invocations of functions that measure various parts of the
>> code and data through various parts of the BIOS code. It follows TCG
>> specifications on what needs to be measured. It also adds the implementation
>> of the called functions.
> Thanks.  I applied this patch.
>
> [...]
>> --- a/src/optionroms.c
>> +++ b/src/optionroms.c
>> @@ -19,6 +19,7 @@
>>   #include "std/pnpbios.h" // PNP_SIGNATURE
>>   #include "string.h" // memset
>>   #include "util.h" // get_pnp_offset
>> +#include "tcgbios.h" // tpm_*
>>   
>>   static int EnforceChecksum, S3ResumeVga, RunPCIroms;
>>   
>> @@ -80,6 +81,7 @@ is_valid_rom(struct rom_header *rom)
>>           if (EnforceChecksum)
>>               return 0;
>>       }
>> +    tpm_option_rom(rom, len);
>>       return 1;
>>   }
> I don't think calling tpm_option_rom() from is_valid_rom() is correct,
> but I (as above) I've applied this patch as is.  I think a future
> change should move the call.  (Is calling it from init_optionrom()
> sufficient?)

Sure, it can also be moved there. After the memmove?

    Stefan