[SeaBIOS] [PATCH] smm: fix outl argument order
Paolo Bonzini
pbonzini at redhat.com
Mon Jul 27 12:23:58 CEST 2015
The value is the first argument and the port is the second, but the code
was using the opposite order.
Reported-by: Stefan Weil <sw at weilnetz.de>
Reviewed-by: Stefan Weil <sw at weilnetz.de>
Signed-off-by: Paolo Bonzini <pbonzini at redhat.com>
---
src/fw/smm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/fw/smm.c b/src/fw/smm.c
index 6cb484e..5145f14 100644
--- a/src/fw/smm.c
+++ b/src/fw/smm.c
@@ -184,7 +184,7 @@ static void piix4_apmc_smm_setup(int isabdf, int i440_bdf)
/* enable SMI generation */
value = inl(acpi_pm_base + PIIX_PMIO_GLBCTL);
- outl(acpi_pm_base + PIIX_PMIO_GLBCTL, value | PIIX_PMIO_GLBCTL_SMI_EN);
+ outl(value | PIIX_PMIO_GLBCTL_SMI_EN, acpi_pm_base + PIIX_PMIO_GLBCTL);
smm_relocate_and_restore();
--
2.4.3
More information about the SeaBIOS
mailing list