[SeaBIOS] bootorder, ATA-SFF, AHCI and CSM; oh my!

Kevin O'Connor kevin at koconnor.net
Sat Jul 25 00:59:43 CEST 2015

On Thu, Jul 23, 2015 at 08:41:46AM -0500, Jonathan A. Kollasch wrote:
> On Tue, Jul 14, 2015 at 03:18:25PM -0400, Kevin O'Connor wrote:
> > On Wed, Jul 08, 2015 at 10:21:57PM -0500, Jonathan A. Kollasch wrote:
> > > On Tue, Jul 07, 2015 at 05:06:03PM -0400, Kevin O'Connor wrote:
> > > > Thanks.  Are you willing to respin a simpler version of the patch?
> > > 
> > > Attached.
> > 
> > I don't think the user visible drive descriptions or the debug strings
> > should change.  How about the patch below instead?
> > 
> > -Kevin
> Looks fine.  But if you're going to add ataid to ata_channel_s you can
> probably also avoid any changes to CSM-mode behavior too.  I had shied
> away from adding a member to ata_channel_s because it was already nicely
> packed (a multiple of 4 bytes).
> Also changing the bootorder names is a user-visible change, one we should
> change, but it's a change none the less, so maybe changing the descriptions
> isn't such a bad thing.  But maybe changing the descriptions should be in a
> different changeset if we do decide to do it.

Thanks.  I committed the patch.

I don't think using the PCI bus/device/function id in the user visible
string makes sense as only hardcore developers would know what that
means.  (It would be confusing to a general user to see ATA at 00b2 or
any similar non-linear identifier.)


More information about the SeaBIOS mailing list