[SeaBIOS] [PATCH] pci: enable SERR# for error forwording in bridge control register
Kevin O'Connor
kevin at koconnor.net
Sat Jan 31 23:58:39 CET 2015
On Wed, Jan 28, 2015 at 11:21:35PM +0100, Paul Menzel wrote:
> Dear Chen,
>
>
> thank you for your patch.
>
> You misspelled `forw*a*rding` in the summary and the comment. I have
> some more nitpicks.
>
>
> Am Mittwoch, den 28.01.2015, 16:05 +0800 schrieb Chen Fan:
> > For PCIe device support AER(Advanced Error Reporting), from the
>
> Please add a space before `(`.
Hi Paul,
Thanks for reviewing the patch. I agree that the comments in the code
should be spelled correctly. However, I don't think we need to be
that picky about the commit comments - the commit comments do need to
be understandable and descriptive of the change - but if it's
understandable we shouldn't need multiple submit cycles for an
otherwise good change.
-Kevin
More information about the SeaBIOS
mailing list