[SeaBIOS] [PATCH] Add option to only execute CBFS option ROMs

Paul Menzel paulepanter at users.sourceforge.net
Mon Feb 9 23:53:30 CET 2015


Am Montag, den 09.02.2015, 11:57 -0600 schrieb Timothy Pearson:
> On 02/09/2015 03:28 AM, Paolo Bonzini wrote:
> >
> > On 06/02/2015 22:13, Timothy Pearson wrote:
> >> +    config CBFS_OPTIONROMS_ONLY
> >> +        depends on OPTIONROMS
> >
> > Probably "depends on OPTIONROMS&&  COREBOOT_FLASH" is better.
> >
> >> +        bool "Only execute option ROMs stored in CBFS"
> >> +        default "n"
> >> +        help
> 
> Do I need to send in an updated patch?

Yes, that would be great! Please tag it as `v2`, i. e., `[PATCH v2]`. If
you use `git format-patch`, you can use the switch `--subject-prefix`
for that. See `git help format-patch` for more information. But for just
one patch it is probably easier to manually edit the subject line in
your mail client.

Please send patches that can be applied with `git am`. I think you patch
cannot be applied easily as Git does not detect the commit message.

> Is there anything else that needs to be done before this can be
> merged?

Normally, Kevin, the SeaBIOS main developer, is pretty quick with
reviewing patches. As he has not done so yet, I guess he is on vacation,
sick or traveling. So just wait a little longer. ;-)


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: This is a digitally signed message part
URL: <http://www.seabios.org/pipermail/seabios/attachments/20150209/d7b49fa6/attachment.asc>


More information about the SeaBIOS mailing list