[SeaBIOS] [PATCH 2/8] tpm: No need to check the return status of measurements
Stefan Berger
stefanb at linux.vnet.ibm.com
Thu Dec 31 01:09:54 CET 2015
On 12/30/2015 02:31 PM, Kevin O'Connor wrote:
> The low-level measurement functions already handle error conditions,
> there is no need to check for the errors in the high level measurement
> functions.
>
> Signed-off-by: Kevin O'Connor <kevin at koconnor.net>
> ---
> @@ -507,7 +478,12 @@ tpm_setup(void)
> if (runningOnXen())
> return;
This looks like a for Xen where we will be missing too much. Cc'in Xu
Quan for this. I think Xen likely only wants to skip the TPM_Startup in
tpm_startup() but not the retrieval of the durations and timeouts and so
on. This part may need to move.
>
> - tpm_startup();
> + ret = tpm_startup();
> + if (ret)
> + return;
> +
> + tpm_smbios_measure();
> + tpm_add_action(2, "Start Option ROM Scan");
> }
Stefan
More information about the SeaBIOS
mailing list