[SeaBIOS] [PATCH 03/10] tpm: Simplify hardware probe and detection checks

Kevin O'Connor kevin at koconnor.net
Thu Dec 31 01:13:50 CET 2015

On Wed, Dec 30, 2015 at 07:06:58PM -0500, Kevin O'Connor wrote:
> On Wed, Dec 30, 2015 at 06:57:23PM -0500, Stefan Berger wrote:
> > On 12/29/2015 07:17 PM, Kevin O'Connor wrote:
> > >+static u8 TPM_working;
> > 
> > Should this not also have VARLOW to not be ROM'ed?
> The only code that runs after normal variables are made read-only is
> the 16bit BIOS interface.  After a later patch ("Don't call
> tpm_set_failure() from tpm_log_extend_event()") none of the 16bit BIOS
> interface functions call tpm_set_failure and thus none attempt to
> modify TPM_working.  Unless I've missed something.
> That later patch probably should be ahead of this patch.

Actually, tpm_add_cdrom* and tpm_add_bcv are called with the variables
read-only, so I think you are correct and the above code is wrong.


More information about the SeaBIOS mailing list