[SeaBIOS] [PATCH 10/10] tpm: Return returnCode from build_and_send_cmd() instead of via pointer param

Kevin O'Connor kevin at koconnor.net
Wed Dec 30 05:28:41 CET 2015

On Tue, Dec 29, 2015 at 10:11:14PM -0500, Stefan Berger wrote:
> On 12/29/2015 07:17 PM, Kevin O'Connor wrote:
> >The callers interested in the return status of build_and_send_cmd()
> >are only interested in the command return code status (returnCode) and
> >not the status of the message transmission (rc).  Simplify the callers
> >by returning returnCode directly instead of via a pointer parameter.
> >For the unlikely case that the command transmission fails, return -1
> >to signal the failure to the callers.
> >
> >Signed-off-by: Kevin O'Connor <kevin at koconnor.net>
> I looked through all of the patches. I tested them (with the bug fixed) and
> from what I can see it still behaves the same way as before. So please,
> apply them. Any more changes coming from you ?

Thanks.  I was looking at a couple of minor changes (mostly reducing
redundant dprintf).  Nothing important.  I pushed my work tree to:


Did you have patches pending?


More information about the SeaBIOS mailing list