[SeaBIOS] [PATCH 1/2] scsi: Do not call printf() from scsi_is_ready()

Kevin O'Connor kevin at koconnor.net
Mon Dec 28 18:15:32 CET 2015


On Wed, Dec 23, 2015 at 03:48:48PM -0500, Kevin O'Connor wrote:
> The scsi_is_ready() function may be called from a thread, and it is
> not valid to call printf() from a thread.  Convert printf() to
> dprintf() to avoid this possibility.
> 
> This does mean that cdrom detection (from cdrom_boot() ) may not give
> notification of slow cdrom drives to a user.  However, the extra
> medium detection time is unlikely to be large anyway.

FYI, I committed this change.

-Kevin



More information about the SeaBIOS mailing list