[SeaBIOS] [PATCH 2/2] block: Report drive->sectors using "%u" instead of "%d"
Kevin O'Connor
kevin at koconnor.net
Wed Dec 23 21:48:49 CET 2015
The sector count is a 64bit number that is often reported as a 32bit
number (due to limitations in dprintf). Consistently use "%u"
reporting to avoid confusing negative numbers.
Reported-by: Tobias Diedrich <tobiasdiedrich at gmail.com>
Signed-off-by: Kevin O'Connor <kevin at koconnor.net>
---
src/block.c | 2 +-
src/hw/blockcmd.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/block.c b/src/block.c
index 1762e2a..b4530fc 100644
--- a/src/block.c
+++ b/src/block.c
@@ -162,7 +162,7 @@ setup_translation(struct drive_s *drive)
// clip to 1024 cylinders in lchs
if (cylinders > 1024)
cylinders = 1024;
- dprintf(1, "drive %p: PCHS=%u/%d/%d translation=%s LCHS=%d/%d/%d s=%d\n"
+ dprintf(1, "drive %p: PCHS=%u/%d/%d translation=%s LCHS=%d/%d/%d s=%u\n"
, drive
, drive->pchs.cylinder, drive->pchs.head, drive->pchs.sector
, desc
diff --git a/src/hw/blockcmd.c b/src/hw/blockcmd.c
index 0725b46..093c5d7 100644
--- a/src/hw/blockcmd.c
+++ b/src/hw/blockcmd.c
@@ -232,7 +232,7 @@ scsi_drive_setup(struct drive_s *drive, const char *s, int prio)
return -1;
}
drive->sectors = (u64)be32_to_cpu(capdata.sectors) + 1;
- dprintf(1, "%s blksize=%d sectors=%d\n"
+ dprintf(1, "%s blksize=%d sectors=%u\n"
, s, drive->blksize, (unsigned)drive->sectors);
// We do not recover from USB stalls, so try to be safe and avoid
--
2.5.0
More information about the SeaBIOS
mailing list