[SeaBIOS] [PATCH] build: Require "make VERSION=x" parameter to be on command line

Paul Menzel paulepanter at users.sourceforge.net
Thu Aug 13 05:59:42 CET 2015


Am Mittwoch, den 12.08.2015, 18:32 -0400 schrieb Kevin O'Connor:
> Don't pull in VERSION from the build environment - there is too great
> a potential for a variable conflict.
> 
> Signed-off-by: Kevin O'Connor <kevin at koconnor.net>
> ---
>  Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Makefile b/Makefile
> index e287530..220a9f7 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -26,6 +26,7 @@ PYTHON=python
>  CPP=cpp
>  IASL:=iasl
>  LD32BIT_FLAG:=-melf_i386
> +VERSION:=

What about changing the name to `SEABIOS_VERSION` instead to avoid
possible conflicts?


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: This is a digitally signed message part
URL: <http://www.seabios.org/pipermail/seabios/attachments/20150813/03d7193c/attachment.asc>


More information about the SeaBIOS mailing list