[SeaBIOS] [PATCH] xhci: Count new Max Scratchpad Bufs bits from XHCI 1.1

Kevin O'Connor kevin at koconnor.net
Mon Aug 10 16:28:16 CET 2015

On Fri, Aug 07, 2015 at 08:07:12PM -0700, Julius Werner wrote:
> The 1.1 revision of the XHCI specification added an extra 5 bits to the
> Max Scratchpad Bufs field of HCSPARAMS2 that newer controllers make use
> of. Not honoring these bits means we're not allocating as many
> scratchpad buffers as the controller expects, which means it will
> interpret some uninitialized values from the end of the pointer array as
> scratchpad buffer pointers.
> We just fixed this in libpayload and it seems to apply the same way to
> SeaBIOS (I only compile-tested this, though... sorry).

Thanks - I committed this change.

If a controller requires that much reserved ram, it will likely lead
to an out of memory error in the current seabios code.  (But an error
is much preferable to a silent failure.)


More information about the SeaBIOS mailing list