[SeaBIOS] [PATCH 1/2] vgabios: Add config option for assembler fixups

[Kevin O'Connor]

On Sat, Apr 11, 2015 at 05:36:53PM +0200, Peter Stuge wrote:
> Kevin O'Connor wrote:
> > +++ b/vgasrc/vgaentry.S
> > @@ -64,6 +64,7 @@ x86emu_fault:
> >          // This macro implements a call while avoiding instructions
> >          // that old versions of x86emu have problems with.
> >          .macro VGA_CALLL cfunc
> > +#if CONFIG_VGA_FIXUP_ASM
> >          // Make sure leal instruction works.
> 
> Isn't the logic backwards here?

Are you pointing out the trap only being enabled when
CONFIG_VGA_FIXUP_ASM is on?  The trap is only useful if doing asm
fixups as some x86emu versions do support leal, but will silently
crash on other instructions (such as calll).  In any case, the next
patch completely eliminates the trap.

I only expect CONFIG_VGA_FIXUP_ASM to be off for those debugging
something.

> 
> Very nice work on this patchset! :)

Thanks,
-Kevin