[SeaBIOS] new tag request for seabios
Pandey, Sunil K
sunil.k.pandey at intel.com
Fri Nov 21 20:04:47 CET 2014
Thanks for response. Following are specific change I'm talking about. Compilers are not expected to create .rodata.str1.1, .rodata.__func__ and .rodata.__PRETTY_FUNCTION__. If compiler decide to use some other .rodata__ suffix name in place of __func__, __PRETTY_FUNCTION__ or str1.1, it breaks the compilation.
As you can see someone already taken out that check from SeaBios mainline, but 18.104.22.168 still has. As a result of this assumption, whenever I try to build SeaBios with Intel Compiler it Fail because Intel compiler uses some other character in place of __PRETTY_FUNCTION__ and __func__. It will be great if you can incorporate this fix in released version.
Layoutrom.py file check for
From SeaBios mainline (layoutrom.py):
180 rodatasections = getSectionsPrefix(sections16, '.rodata')
193 rodatasections = getSectionsPrefix(sections32seg, '.rodata')
From 22.214.171.124 (layoutrom.py):
178 rodatasections = (
179 getSectionsPrefix(li.sections16, '.rodata.str1.1')␊
180 + getSectionsPrefix(li.sections16, '.rodata.__func__.')
181 + getSectionsPrefix(li.sections16, '.rodata.__PRETTY_FUNCTION__.'))
194 rodatasections = (
195 getSectionsPrefix(li.sections32seg, '.rodata.str1.1')
196 + getSectionsPrefix(li.sections32seg, '.rodata.__func__.')
197 + getSectionsPrefix(li.sections32seg, '.rodata.__PRETTY_FUNCTION__.'))
From: Kevin O'Connor [mailto:kevin at koconnor.net]
Sent: Friday, November 21, 2014 10:42 AM
To: Pandey, Sunil K
Cc: 'seabios at seabios.org'
Subject: Re: [SeaBIOS] new tag request for seabios
On Wed, Nov 12, 2014 at 09:20:22PM +0000, Pandey, Sunil K wrote:
> I'm looking for a fix in
> m.py file. Apparently the fix is already in the master, but it's hard
> for me to use directly from master. Currently all existing tags are
> old and doesn't reflect latest layoutrom.py changes.
> Can you please create a new tag from master so that I can use it in my
> project? I'm trying to compile seabios code with Intel compiler, but
> it keep failing because of layoutrom.py file __func__ check.
Can you post the error that you are seeing?
We just tagged rel-126.96.36.199 and it included all the build bug fixes that I know of. There are changes to scripts/layoutrom.py between
rel-188.8.131.52 and the current master branch, but none of those changes were thought to be bug fixes.
PS - please post in just plain text (no html) in the future.
More information about the SeaBIOS