[SeaBIOS] [PATCH 0/5] SMM improvements

Paolo Bonzini pbonzini at redhat.com
Wed May 28 18:33:05 CEST 2014

Il 28/05/2014 18:04, Kevin O'Connor ha scritto:
> On Fri, May 16, 2014 at 09:29:59AM +0200, Paolo Bonzini wrote:
>> Il 15/05/2014 20:57, Kevin O'Connor ha scritto:
>>> On Thu, May 15, 2014 at 06:36:08PM +0200, Paolo Bonzini wrote:
>>>> I think this is more easily visible on top of these patches more than the
>>>> other way round, but I'm biased of course...
>>> I was referring to your patch 5, which adds a bunch of assembler
>>> variables - I think it would be clearer to add them in C to start.
>> Ah, sure.  The C conversion patch belongs between patch 4 and patch 5 in
>> this series, roughly.
> FYI, I rebased your first four patches on to the seabios tip and then
> applied my "SMM in C" patch on top of that.  There were several
> conflicts during the merge of your patches, so I hope I got them
> correct.  The series is at:
> https://github.com/KevinOConnor/seabios/commits/work-smm-in-c-20140528

Looks great.

Passing CS to handle_smi is not strictly necessary; you could instead 
just reserve writing some value (e.g. 0x00) to port 0xb2 for relocation. 
  That's really my only comment.  I will rewrite patch 5 in C as soon as 
your series hits master.


More information about the SeaBIOS mailing list