[SeaBIOS] [RFC PATCH] SMBIOS: Turn on VM flag on default type 0 structure

Gabriel L. Somlo gsomlo at gmail.com
Tue May 13 20:48:04 CEST 2014


Since commit d85c22e44ee4e24f2be19d579ea8fa0066a85fbb,
when pulling aggregate tables from fw_cfg, we generate
a default type 0 (bios info) structure if one isn't
already provided.

This patch enables the "virtual machine" bit within the
bios_characteristics_extension_bytes field of the default
type 0 structure.

Signed-off-by: Gabriel Somlo <somlo at cmu.edu>
---

What do you all think, does it make sense to flip on the
"virtual machine" bit when generating a default Bios Info
(type 0) table to go along with everything else we received
via fw_cfg ?

If yes, please apply :)

Thanks,
  Gabriel

 src/fw/biostables.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/fw/biostables.c b/src/fw/biostables.c
index 17bee8e..64f3157 100644
--- a/src/fw/biostables.c
+++ b/src/fw/biostables.c
@@ -350,9 +350,10 @@ smbios_new_type_0(void *start,
     memset(p->bios_characteristics, 0, 8);
     p->bios_characteristics[0] = 0x08;
 
-    /* Enable targeted content distribution (needed for SVVP) */
+    /* Enable targeted content distribution (needed for SVVP);
+     * Also enable "virtual machine" bit: */
     p->bios_characteristics_extension_bytes[0] = 0;
-    p->bios_characteristics_extension_bytes[1] = 4;
+    p->bios_characteristics_extension_bytes[1] = 0x14; /* TCG/SVVP | VM */
 
     p->system_bios_major_release = 0;
     p->system_bios_minor_release = 0;
-- 
1.9.0




More information about the SeaBIOS mailing list