[SeaBIOS] [PATCH 0/4] Unify and fix USB command timeouts.

Kevin O'Connor kevin at koconnor.net
Wed Jun 18 17:04:58 CEST 2014


On Sat, Jun 14, 2014 at 02:08:49PM -0400, Kevin O'Connor wrote:
> The SeaBIOS USB drivers all have different timeouts for USB commands.
> The USB specification does specify maximum command times (section
> 9.2.6).  In particular, it states that all commands are expected to
> complete within 5 seconds.
> 
> This series unifies the command timeouts across the drivers.
> Generally, the timeout is increased to 5 seconds for all commands.
> This fixes an issue reported by some users of USB flash drives on XHCI
> controllers (the xhci controller had a 1 second bulk timeout).
> 
> The control command timeouts are also increased to 5 seconds except
> for the set_address command.  This is reduced to 150ms (spec caps
> device to 50ms) to prevent 5 second hangs should a port report a
> device that isn't actually there.  Once the driver starts talking to a
> device it would be very unusual to timeout on a command, so there
> shouldn't be any problem with a limit of five seconds.

FYI, I have pushed this series.

-Kevin



More information about the SeaBIOS mailing list