[SeaBIOS] [[PATCH] ] Prevent build failure by not splitting line in the middle of arguments to checkrom.py script

Sander Eikelenboom linux at eikelenboom.it
Fri Jan 10 19:17:08 CET 2014


Friday, January 10, 2014, 7:14:15 PM, you wrote:

> On Fri, Jan 10, 2014 at 10:00:13AM +0100, Sander Eikelenboom wrote:
>> 
>> Friday, January 10, 2014, 2:13:42 AM, you wrote:
>> 
>> > On Thu, Jan 09, 2014 at 08:18:43PM +0100, Sander Eikelenboom wrote:
>> >> File "./scripts/checkrom.py", line 24, in main
>> >>     objinfo, finalsize, rawfile, outfile = sys.argv[1:]
>> >> ValueError: need more than 3 values to unpack
>> 
>> > That doesn't fail for me - what OS / distribution are you using to
>> > build?
>> 
>> It occurs when building as part of Xen, on Debian wheezy.

> Thanks.  I suspect there must be something else contributing to the
> failure, but your patch makes sense so I have pushed it to the main
> repo.

I didn't saw any other python line being wrapped in that Makefile, although there were even longer ones
and i don't know if it uses that checkrom.py script on every build.

Any how thx !

> -Kevin





More information about the SeaBIOS mailing list