[SeaBIOS] [PATCH] Fix layoutrom step on i18n-equipped systems

Kevin O'Connor kevin at koconnor.net
Wed Dec 3 15:58:26 CET 2014


On Wed, Dec 03, 2014 at 11:16:39AM +0100, Gerd Hoffmann wrote:
> On Di, 2014-12-02 at 10:40 -0500, Kevin O'Connor wrote:
> > On Mon, Dec 01, 2014 at 10:56:09PM +0100, Patrick Georgi wrote:
> > > objdump output parsing expects C locale strings
> > > and formatting. Make sure it gets what it requires.
> > > 
> > > Signed-off-by: Patrick Georgi <pgeorgi at google.com>
> > 
> > Thanks.
> > 
> > Your patch misses the call to OBJDUMP in bios.bin.prep though.  Does
> > the alternate patch below work?
> 
> I suspect this isn't going to fly as each makefile line is run
> separately.

Yeah - Patrick pointed that out to me separately.

> 
> How about this:
> 
> diff --git a/Makefile b/Makefile
> index 7c2b33c..f2f80e2 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -12,6 +12,7 @@ export HOSTCC             := $(CC)
>  export CONFIG_SHELL       := sh
>  export KCONFIG_AUTOHEADER := autoconf.h
>  export KCONFIG_CONFIG     := $(CURDIR)/.config
> +export LC_ALL             := C

Does that impact kconfig?

-Kevin



More information about the SeaBIOS mailing list