[SeaBIOS] [QEMU v8 PATCH 0/7] SMBIOS: build full tables in QEMU
Gabriel L. Somlo
gsomlo at gmail.com
Wed Apr 23 15:42:35 CEST 2014
On Wed, Apr 23, 2014 at 12:13:48PM +0200, Gerd Hoffmann wrote:
> Series looks good to me.
Awesome, thanks! Here's one more iteration, rearranging things
to start with the most benign and uncontroversial patches, and
progressing toward the "payload" at the end :)
> /me wonders though how you've tested the final revision and the compat
> stuff. Patch #6 doesn't actually add a new machine type where the
> non-legacy mode is active ...
Why, by commenting and uncommenting "smbios_legacy_mode = true;"
in the *compat_2_0() functions :) I realized I was being silly
after sending out the v7 series, and added something more or less
similar to what you wrote, and was saving it for v8. I squashed it
on top of the compat functions, see patch 2/7.
> I'll go wait for a few days for additional feedback, then [...]
> send out a pull request.
Sounds like a plan! BTW, would it make sense to have Kevin apply
to SeaBIOS and then pull a new blob from there around the same
time (or before ?) this patch set is applied to QEMU ?
Gabriel L. Somlo (7):
E820: Add interface for accessing e820 table
PC: Add machine version 2.1 for piix and q35
SMBIOS: Rename symbols to better reflect future use
SMBIOS: Update header file definitions
SMBIOS: Use macro to set smbios defaults
SMBIOS: Use bitmaps to prevent incompatible comand line options
SMBIOS: Build aggregate smbios tables and entry point
hw/i386/pc.c | 39 ++-
hw/i386/pc_piix.c | 43 ++-
hw/i386/pc_q35.c | 37 ++-
hw/i386/smbios.c | 789 +++++++++++++++++++++++++++++++++++++++++++----
include/hw/i386/pc.h | 2 +
include/hw/i386/smbios.h | 99 ++++--
6 files changed, 902 insertions(+), 107 deletions(-)
More information about the SeaBIOS