[SeaBIOS] [QEMU v5 PATCH 02/18] SMBIOS: Use macro to set smbios defaults
Gabriel L. Somlo
gsomlo at gmail.com
Fri Apr 11 18:11:42 CEST 2014
The function smbios_set_defaults() uses a repeating code pattern
for each field. This patch replaces that pattern with a macro.
Signed-off-by: Gabriel Somlo <somlo at cmu.edu>
---
hw/i386/smbios.c | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/hw/i386/smbios.c b/hw/i386/smbios.c
index 89dc070..f4ee7b4 100644
--- a/hw/i386/smbios.c
+++ b/hw/i386/smbios.c
@@ -256,18 +256,17 @@ static void smbios_build_type_1_fields(void)
}
}
+#define SMBIOS_SET_DEFAULT(field, value) \
+ if (!field) { \
+ field = value; \
+ }
+
void smbios_set_defaults(const char *manufacturer,
const char *product, const char *version)
{
- if (!type1.manufacturer) {
- type1.manufacturer = manufacturer;
- }
- if (!type1.product) {
- type1.product = product;
- }
- if (!type1.version) {
- type1.version = version;
- }
+ SMBIOS_SET_DEFAULT(type1.manufacturer, manufacturer);
+ SMBIOS_SET_DEFAULT(type1.product, product);
+ SMBIOS_SET_DEFAULT(type1.version, version);
}
uint8_t *smbios_get_table(size_t *length)
--
1.9.0
More information about the SeaBIOS
mailing list