[SeaBIOS] [PATCH v4 4/5] acpi: load and link tables through romfile loader

[Gerd Hoffmann]

On Mi, 2013-09-25 at 13:51 +0300, Michael S. Tsirkin wrote:
> On Wed, Sep 25, 2013 at 12:24:18PM +0200, Gerd Hoffmann wrote:
> >   Hi,
> > 
> > > Imagine you have QEMU 1.7. You want to update bios,
> > > so you pull latest source.
> > > Of course roms/config.seabios-128k does not know which
> > > flags to set :(
> > 
> > Hmm?  That is the whole point of the file, to carry the (non-default)
> > config options ...
> > 
> > Latest qemu should have a up-to-date info for latest seabios release.
> > When updating seabios to not-yet released master you better know what
> > you are doing, I don't think there is a need to make that bullet-proof.
> > 
> > cheers,
> >   Gerd
> > 
> 
> Simply put - it's in a separate tree so it will be foreever out of sync.

It may happen now and then.  It's not like we are changing the config
daily.

> Example: you want to try and reproduce a bug with latest seabios.
> You build it with options from which qemu?

In most cases you can just go with the default config and be done with
it, with cross version live migration testing being pretty much the only
exception.

> config options is also not an interface we can support.
> So there will be pain when we rename some option.

When doing it the other way around flipping an config option for -- say
the 128k rom -- will be a pain:

  (1) patch seabios
  (2) wait for next seabios release
  (3) update seabios in qemu to the new release

Of course you can take a shortcut and just update
roms/config.seabios-128k in qemu instead.  Assuming the kconfig
dependencies allow to do that.

I think it is easier to just have the config in
roms/config.seabios-128k ...

cheers,
  Gerd