[SeaBIOS] [PATCH] vga: Don't advertise multiple pages for lfb modes.

Kevin O'Connor kevin at koconnor.net
Fri Sep 13 22:37:56 CEST 2013

On Wed, Sep 11, 2013 at 12:45:27PM +0200, Gerd Hoffmann wrote:
> Retested, figured with seavgabios win8 modeswitching works just fine,
> even without the patch.  /me is puzzled, I'm sure I've tried that before
> and it didn't work.

Okay, so no patch is necessary?  I think it might be worthwhile to
clamp the pages value to a number between 1-127 - see the patch I sent

> > +        dprintf(1, "mode=%02x x=%d y=%d d=%d pages=%d\n", videomode
> > +                , mode_info->xres, mode_info->yres, mode_info->bits_per_pixel
> > +                , mode_info->pages);
> While wading through the source I've noticed mode_info has not only
> "pages", but also "linear_pages" and "bank_pages" fields (new for vbe3).
> seavgabios doesn't set them.  Should it?

I don't know.  The VBE3 support is fairly limited - if the spec calls
for it then I'd say it makes sense to fill it in.  In practice, I
suspect very few programs (if any) care what VBE reports.


More information about the SeaBIOS mailing list