[SeaBIOS] [PATCH] pvscsi boot support

[Paul Menzel]

Dear Evgeny,


thank you for the patch!


Am Sonntag, den 06.10.2013, 14:14 +0300 schrieb Evgeny Budilovsky:

Is this version 2 of the patch from »Sun,  6 Oct 2013 13:23:26 +0300«?
Did you just remove the first Signed-off-by line? (Please mark different
iterations in the subject line, like »[PATCH v3]«. See
`--subject-prefix=Subject-Prefix` in `git help format-patch`.)

> Signed-off-by: Evgeny Budilovsky <evgeny.budilovsky at ravellosystems.com>
> ---
>  Makefile          |    2 +-
>  src/Kconfig       |    6 +
>  src/block.c       |    1 +
>  src/block.h       |    1 +
>  src/hw/blockcmd.c |    3 +
>  src/hw/pci_ids.h  |    3 +
>  src/hw/pvscsi.c   |  365 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  src/hw/pvscsi.h   |    8 ++
>  src/post.c        |    2 +
>  9 files changed, 390 insertions(+), 1 deletion(-)
>  create mode 100644 src/hw/pvscsi.c
>  create mode 100644 src/hw/pvscsi.h

How did you test this? Does everything work?

> diff --git a/Makefile b/Makefile
> index 3218970..6c6302e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -34,7 +34,7 @@ SRCBOTH=misc.c stacks.c output.c string.c x86.c block.c cdrom.c mouse.c kbd.c \
>      hw/usb-hid.c hw/usb-msc.c hw/usb-uas.c \
>      hw/blockcmd.c hw/floppy.c hw/ata.c hw/ahci.c hw/ramdisk.c \
>      hw/virtio-ring.c hw/virtio-pci.c hw/virtio-blk.c hw/virtio-scsi.c \
> -    hw/lsi-scsi.c hw/esp-scsi.c hw/megasas.c
> +    hw/lsi-scsi.c hw/esp-scsi.c hw/megasas.c hw/pvscsi.c
>  SRC16=$(SRCBOTH) system.c disk.c font.c
>  SRC32FLAT=$(SRCBOTH) post.c memmap.c malloc.c pmm.c romfile.c optionroms.c \
>      boot.c bootsplash.c jpeg.c bmp.c \
> diff --git a/src/Kconfig b/src/Kconfig
> index c40cc61..e4967d2 100644
> --- a/src/Kconfig
> +++ b/src/Kconfig
> @@ -161,6 +161,12 @@ menu "Hardware support"
>          default y
>          help
>              Support boot from virtio-scsi storage.
> +    config PVSCSI
> +        depends on DRIVES && QEMU_HARDWARE
> +        bool "pvscsi controllers"
> +        default y
> +        help
> +            Support boot from pvscsi storage.

Could you at list write »Paravirtualized SCSI« out once, please? So
people grepping for that can find it too. Not sure if if the
abbreviation should be written all upper case like in the Wiki [1]. I do
not know if that is the official spelling.

[…]


Thanks,

Paul


[1] http://wiki.xen.org/wiki/Paravirtualized_SCSI
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://www.seabios.org/pipermail/seabios/attachments/20131007/044070d4/attachment.sig>