[SeaBIOS] another iasl update breaks seabios compilation again

Michael Tokarev mjt at tls.msk.ru
Thu May 9 16:48:17 CEST 2013


[Resending after being subscribed to the list]

I'm not sure what happened yet, but I noticed that current seabios
does not build with 20130214-32 version of iasl.

Apparently, the listing file (-l) produced now does not contain
any comments from the original source, so tools/acpi_extract.py
produce nothing from these files.

Here's the diff between listing produced by two versions of iasl
for ssdt-pcihp:

----------------

--- out/ssdt-pcihp.lst-20100528	2013-05-09 17:55:43.872160687 +0400
+++ out/ssdt-pcihp.lst-20130214-32	2013-05-09 17:57:45.222803783 +0400
@@ -1,84 +1,72 @@

 Intel ACPI Component Architecture
-ASL Optimizing Compiler version 20100528 [Jul  2 2010]
-Copyright (c) 2000 - 2010 Intel Corporation
-Supports ACPI Specification Revision 4.0a
-
-Compilation of "out/ssdt-pcihp.dsl.i" - Thu May  9 17:55:43 2013
-
-       1....
-       2..../* ACPI_EXTRACT_ALL_CODE ssdp_pcihp_aml */
-       3....
-       4....DefinitionBlock ("ssdt-pcihp.aml", "SSDT", 0x01, "BXPC", "BXSSDTPCIHP", 0x1)
-
-00000000....53 53 44 54 58 00 00 00     "SSDTX..."
-00000008....01 77 42 58 50 43 00 00     ".wBXPC.."
-00000010....42 58 53 53 44 54 50 43     "BXSSDTPC"
-00000018....01 00 00 00 49 4E 54 4C     "....INTL"
-00000020....28 05 10 20 ............    "(.. "
-
-       5....{
-       6....    External(\_SB.PCI0, DeviceObj)
-       7....    External(\_SB.PCI0.PCEJ, MethodObj)
-       8....    Scope(\_SB.PCI0) {
-
-00000024....10 33 5C 2E 5F 53 42 5F     ".3\._SB_"
-0000002C....50 43 49 30 ............    "PCI0"
-
-       9....
-      10..../* ACPI_EXTRACT_DEVICE_START ssdt_pcihp_start */
-      11....
-      12....
-      13..../* ACPI_EXTRACT_DEVICE_END ssdt_pcihp_end */
-      14....
-      15....
-      16..../* ACPI_EXTRACT_DEVICE_STRING ssdt_pcihp_name */
-      17....
-      18....        Device(SAA) {
-
-00000030....5B 82 26 53 41 41 5F ...    "[.&SAA_"
-
-      19....
-      20..../* ACPI_EXTRACT_NAME_BYTE_CONST ssdt_pcihp_id */
-      21....
-      22....            Name(_SUN, 0xAA)
-
-00000037....08 5F 53 55 4E 0A AA ...    "._SUN.."
-
-      23....
-      24..../* ACPI_EXTRACT_NAME_DWORD_CONST ssdt_pcihp_adr */
-      25....
-      26....            Name(_ADR, 0xAA0000)
-
-0000003E....08 5F 41 44 52 0C 00 00     "._ADR..."
-00000046....AA 00 ..................    ".."
-
-      27....
-      28..../* ACPI_EXTRACT_METHOD_STRING ssdt_pcihp_ej0 */
-      29....
-      30....            Method(_EJ0, 1) {
-
-00000048....14 0F 5F 45 4A 30 01 ...    ".._EJ0."
-
-      31....                Return (PCEJ(_SUN))
-
-0000004F....A4 .....................    "."
-00000050....50 43 45 4A 5F 53 55 4E     "PCEJ_SUN"
-      32....            }
-      33....        }
-      34....    }
-      35....}
-      36....
+ASL Optimizing Compiler version 20130214-32 [Apr  6 2013]
+Copyright (c) 2000 - 2013 Intel Corporation
+
+Compilation of "out/ssdt-pcihp.dsl.i" - Thu May  9 17:57:45 2013
+
+       4:  DefinitionBlock ("ssdt-pcihp.aml", "SSDT", 0x01, "BXPC", "BXSSDTPCIHP", 0x1)
+
+00000000:  53 53 44 54 58 00 00 00     "SSDTX..."
+00000008:  01 8B 42 58 50 43 00 00     "..BXPC.."
+00000010:  42 58 53 53 44 54 50 43     "BXSSDTPC"
+00000018:  01 00 00 00 49 4E 54 4C     "....INTL"
+00000020:  14 02 13 20 ............    "... "
+
+       5:  {
+       6:      External(\_SB.PCI0, DeviceObj)
+       7:      External(\_SB.PCI0.PCEJ, MethodObj)
+       8:      Scope(\_SB.PCI0) {
+
+00000024:  10 33 5C 2E 5F 53 42 5F     ".3\._SB_"
+0000002C:  50 43 49 30 ............    "PCI0"
+
+      18:          Device(SAA) {
+
+00000030:  5B 82 26 53 41 41 5F ...    "[.&SAA_"
+
+      22:              Name(_SUN, 0xAA)
+
+00000037:  08 5F 53 55 4E 0A AA ...    "._SUN.."
+
+      26:              Name(_ADR, 0xAA0000)
+
+0000003E:  08 5F 41 44 52 0C 00 00     "._ADR..."
+00000046:  AA 00 ..................    ".."
+
+      30:              Method(_EJ0, 1) {
+
+00000048:  14 0F 5F 45 4A 30 01 ...    ".._EJ0."
+
+      31:                  Return (PCEJ(_SUN))
+
+[****iasl****]
+out/ssdt-pcihp.dsl.i     31:                 Return (PCEJ(_SUN))
+Warning  1104 -                                        ^ Reserved method should not return a value (_EJ0)
+
+
+
+0000004F:  A4 .....................    "."
+00000050:  50 43 45 4A 5F 53 55 4E     "PCEJ_SUN"
+      32:              }
+      33:          }
+      34:      }
+      35:  }
+


 Summary of errors and warnings

+out/ssdt-pcihp.dsl.i     31:                 Return (PCEJ(_SUN))
+Warning  1104 -                                        ^ Reserved method should not return a value (_EJ0)


-ASL Optimizing Compiler version 20100528 [Jul  2 2010]
-ASL Input:  out/ssdt-pcihp.dsl.i - 37 lines, 767 bytes, 6 keywords
-AML Output: out/ssdt-pcihp.aml - 88 bytes, 5 named objects, 1 executable opcodes
+ASL Optimizing Compiler version 20130214-32 [Apr  6 2013]

-Compilation complete. 0 Errors, 0 Warnings, 0 Remarks, 0 Optimizations
+ASL Input:     out/ssdt-pcihp.dsl.i - 37 lines, 359 bytes, 6 keywords
+AML Output:    out/ssdt-pcihp.aml - 88 bytes, 5 named objects, 1 executable opcodes
+Listing File:  out/ssdt-pcihp.lst - 2016 bytes
+Hex Dump:      out/ssdt-pcihp.hex - 228 bytes

+Compilation complete. 0 Errors, 1 Warnings, 0 Remarks, 0 Optimizations

----------------

As you can see, there's no code comments anymore, so
nothing to output by acpi_extract.py

I haven't digged further yet -- just a heads-up for now.

Thanks,

/mjt



More information about the SeaBIOS mailing list