[SeaBIOS] [PATCH 2/2] accept MADT over fw_cfg

Michael S. Tsirkin mst at redhat.com
Thu Mar 21 13:34:10 CET 2013


On Thu, Mar 21, 2013 at 12:23:45PM +0000, David Woodhouse wrote:
> On Wed, 2013-03-20 at 20:22 -0400, Kevin O'Connor wrote:
> > On Wed, Mar 20, 2013 at 10:53:05PM +0100, Laszlo Ersek wrote:
> > > 
> > > Signed-off-by: Laszlo Ersek <lersek at redhat.com>
> > 
> > I think we need to figure out what the final fw_cfg interface for
> > ACPI, SMBIOS, mptable, and PIR will be.
> 
> Once we have consensus, we can implement this on the OVMF side too. Is
> anyone (Laszlo?) looking at that, or should I?
> 
> 
> > For SMBIOS, I don't think we should use the existing fw_cfg mechanism.
> > It's too complicated for what is needed.  Instead, one fw_cfg "file"
> > entry with the whole smbios table should suffice. 
> 
> Agreed. I'd already looked at doing this in OVMF, and run away
> screaming.
> 
> >  For mptable and PIR, there is no current mechanism, so we can add new
> > fw_cfg "files" for them.  However, for all of these SeaBIOS needs to
> > be able to determine when it needs to create the table and when no
> > table should be published at all.
> 
> I'd make it all-or-nothing. Except for a few historical qemu commits if
> you're bisecting, why would qemu ever provide a *partial* set of tables?

I think we should just get the config from qemu. Pls take a look
at the README patch I posted. It will also help future
extensions.


> -- 
>                    Sent with MeeGo's ActiveSync support.
> 
> David Woodhouse                            Open Source Technology Centre
> David.Woodhouse at intel.com                              Intel Corporation





More information about the SeaBIOS mailing list