[SeaBIOS] [PATCH] acpi: make default DSDT optional

Gerd Hoffmann kraxel at redhat.com
Mon Mar 18 09:43:43 CET 2013


On 03/18/13 09:23, Michael S. Tsirkin wrote:
> On Sun, Mar 17, 2013 at 10:23:21PM -0400, Kevin O'Connor wrote:
>> On Sun, Mar 17, 2013 at 08:32:34PM +0200, Michael S. Tsirkin wrote:
>>> QEMU now loads its own copy of DSDT, so let's not build in PIIX.
>>> This leaves building in the DSDT an option, default to off.
>>> If no one complains for a while, we'll be able to
>>> remove this altogether.
>>
>> Thanks.  I don't think it will be that easy to remove support for this
>> as older versions of QEMU (and all versions of Bochs) wont work
>> properly if the DSDT is not present.  Ultimately, we want to move all
>> of the acpi stuff to qemu - I think we should wait for that before
>> enabling the ability to remove the support in SeaBIOS.
>>
>> -Kevin
> 
> This is exactly what I am working on actually.  There's lost of activity
> related to acpi so keeping this work on a branch until is complete will
> be hard.
> Surely a config option does no harm?
> Maybe you can merge it if I change the default to y?

I think defaulting to 'y' for compatibility with older qemu versions is
a good idea.  For the builds bundled with qemu (where we _know_ qemu is
new enougth that it actually works) we can flip the switch to 'n' (via
roms/config.seabios).

cheers,
  Gerd




More information about the SeaBIOS mailing list