[SeaBIOS] [PATCH 05/13] Add macros for pushing and popping struct bregs

[Kevin OConnor]

On Wed, Jan 30, 2013 at 2:31 PM, David Woodhouse <dwmw2 at infradead.org>wrote:

> On Wed, 2013-01-30 at 09:58 -0700, Marc Jones wrote:
> >
> > > Not-yet-signed-off-by: David Woodhouse <David.Woodhouse at intel.com>
> > would-be-acked-by: Marc Jones <marc.jones at se-eng.com>
>
> Thanks. I've updated the git tree at git://,
> http://git.infradead.org/users/dwmw2/seabios.git accordingly.
>
> The 'not yet' bit has been revoked, btw. The bureaucracy is done and
> it's ready for merging once it's passed review.
>

Thanks.  In general it looks good - I hope to provide more
feedback this weekend.


> The main thing that bothers me is the UMBStart,UMBEnd fields and
> corresponding patch to OVMF; we haven't finalised that side of it yet
> but we certainly *need* it.
>

This bothers me a little as well.  Would it be possible to
separate out the UMBStart/End stuff into a separate patch.  (The
main patch would assume OVMF doesn't lock 0xc0000-0xfffff at all,
and the UMBStart/End patch would assume that OVMF has your
proposed extensions.)

-Kevin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.seabios.org/pipermail/seabios/attachments/20130130/8ca0d466/attachment.html>