[SeaBIOS] [PATCHv2 0/6] Improved multi-platform support

[Ian Campbell]

On Thu, 2013-02-14 at 12:29 +0000, David Woodhouse wrote:
> On Thu, 2013-02-14 at 11:27 +0000, Ian Campbell wrote:
> > I've attached an hvmloader which I just built from the 4.2 stable branch
> > and have smoke tested, does it work for you?
> 
> FFS. Is it too early to start drinking yet? A 256KiB ROM image fails as
> I have described, while a 128KiB image works fine. So turning up the
> debug level — as I had done in all my builds — basically makes it fail.
> 
> If I only turn it up to 3 and then keep turning off the unused
> default-enabled drivers until the image fits in 128KiB again, it works.
> So I'm fairly sure it *is* the size limit.
> 
> Is that a known issue?

I had observed once upon a time that turning up the limit caused odd
failures, but I'd never associated it with the size. I spent ages trying
to track down a NULL pointer in some level>3 message and the like...

In hvmloader I see:
        #define SEABIOS_PHYSICAL_ADDRESS    0x000E0000
which would have to change if the image grew >128K. Really hvmloader
should check the size dynamically and DTRT. I can't remember why I did
it this way.

Sorry about this, crapness on our end I think :-(

I've added this to my TODO list.
Ian.
-- 
Ian Campbell

Most people in this society who aren't actively mad are, at best,
reformed or potential lunatics.
		-- Susan Sontag