[SeaBIOS] [RFC PATCH] VGA BIOS init fails if first mode used is graphical

David Woodhouse dwmw2 at infradead.org
Fri Feb 8 16:19:19 CET 2013


On Fri, 2013-02-08 at 15:06 +0000, David Woodhouse wrote:
> When booting with OVMF+CSM, the first video mode that we ask for is mode
> 0x143. This doesn't seem to work; the qemu display window doesn't change
> size, and remains blank.
> 
> If the first thing we ask for is a *text* mode, then things work fine.
> This is arguably a bug, but I'm not about to go chasing it. 

I should know never to say things like that; if I'm offended by
something it's almost always a lie to say that I won't actually go and
hunt it down. This patch is more minimal and highlights the actual
problem. Not sure what *else* is missing...

Signed-off-by: David Woodhouse <David.Woodhouse at intel.com>

diff --git a/vgasrc/bochsvga.c b/vgasrc/bochsvga.c
index bb5a64d..b0ba1ec 100644
--- a/vgasrc/bochsvga.c
+++ b/vgasrc/bochsvga.c
@@ -319,6 +319,7 @@ bochsvga_set_mode(struct vgamode_s *vmode_g, int flags)
         stdvga_sequ_mask(0x04, 0x00, 0x08);
         stdvga_grdc_mask(0x05, 0x20, 0x40);
     }
+    stdvga_attrindex_write(0x20);
 
     return 0;
 }

-- 
dwmw2

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 6171 bytes
Desc: not available
URL: <http://www.seabios.org/pipermail/seabios/attachments/20130208/da47b1e0/attachment-0001.bin>


More information about the SeaBIOS mailing list