[SeaBIOS] [PATCH 1/3] pvscsi: Don't store reference to struct pci_device.

Kevin O'Connor kevin at koconnor.net
Fri Dec 27 18:17:53 CET 2013


The pci_device reference isn't used by pvscsi, and it's confusing to
keep a long held reference to a short lived object.

Signed-off-by: Kevin O'Connor <kevin at koconnor.net>
---
 src/hw/pvscsi.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/hw/pvscsi.c b/src/hw/pvscsi.c
index 6911230..00ce377 100644
--- a/src/hw/pvscsi.c
+++ b/src/hw/pvscsi.c
@@ -129,7 +129,6 @@ struct pvscsi_ring_dsc_s {
 
 struct pvscsi_lun_s {
     struct drive_s drive;
-    struct pci_device *pci;
     u32 iobase;
     u8 target;
     u8 lun;
@@ -291,7 +290,6 @@ pvscsi_add_lun(struct pci_device *pci, u32 iobase,
     memset(plun, 0, sizeof(*plun));
     plun->drive.type = DTYPE_PVSCSI;
     plun->drive.cntl_id = pci->bdf;
-    plun->pci = pci;
     plun->target = target;
     plun->lun = lun;
     plun->iobase = iobase;
-- 
1.8.3.1




More information about the SeaBIOS mailing list