[SeaBIOS] [PATCH v4] apm: fix shutdown

Sebastian Herbszt herbszt at gmx.de
Mon Aug 12 20:41:37 CEST 2013


Kevin O'Connor wrote:
> On Tue, Jul 30, 2013 at 10:52:12AM +0200, Gerd Hoffmann wrote:
>> Qemu commit 9ee59f3 removed the bochs bios apm interface emulation at
>> port 0x8900.  That broke poweroff via APM.  Fix it by powering off the
>> machine using the acpi pm control register.
>> 
>> Old code is left in, so seabios wil try both poweroff methods.  Cleaning
>> that eventually up is left for another patch, after checking it isn't
>> needed.  Qemu never implemented "Standby" and "Suspend", only
>> "Shutdown", so it looks like there might be non-qemu use cases (bochs
>> probably).
>> 
>> Easiest way to test this is the syslinux poweroff module; modern linux
>> distros usually have CONFIG_APM turned off.
> 
> Looks okay to me.
> 
> -Kevin

Can we get this change into SeaBIOS 1.7.2.x and 1.7.3.x?
It needs to end up in QEMU 1.4.x, 1.5.x and 1.6.0.

Sebastian




More information about the SeaBIOS mailing list